sptk



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: virtual ~CWaiter()?



That's correct. But why are there any virtual functions in
CWaiter? When was the last time you needed to derive
something from it, and especially, when was the last time
you needed to override any of core CWaiter functions?

Alexey Parshin wrote:
Several compilers suggest: If the class has anything virtual - it should
have virtual dtor. One of such compilers is GCC 3.4..3.6 (IIRC).

I'm not sure - why cppserv hangs with that change. But, it's possible that
indicates some problem in cppserv. We can take virtual out, but it wouldn't
fix that problem.

2008/12/12 Ilya A. Volynets-Evenbakh <ilya@total-knowledge.com>

Hey. I just noticed that you made CWaiter destructor virtual.
I also noticed that it makes cppserv under valgrind hang while
accepting requests.

Before I dive any further, why did you decide to make it virtual?

  Ilya.






List hosted by Total Knowledge

Authoright © Total Knowledge: 2005