I don't recall using virtual abilities of CWaiter. But, I don't see why we should change correct/working code just for workaround of cppserv problem? This isn't the source of the problem, anyway. This is just a side effect. OTOH, once defined this way, CWaiter is extremely flexible, and some projects may use it its virtual capabilities already. 2008/12/12 Ilya A. Volynets-Evenbakh <ilya@total-knowledge.com> > That's correct. But why are there any virtual functions in > CWaiter? When was the last time you needed to derive > something from it, and especially, when was the last time > you needed to override any of core CWaiter functions? > > > Alexey Parshin wrote: > >> Several compilers suggest: If the class has anything virtual - it should >> have virtual dtor. One of such compilers is GCC 3.4..3.6 (IIRC). >> >> I'm not sure - why cppserv hangs with that change. But, it's possible that >> indicates some problem in cppserv. We can take virtual out, but it >> wouldn't >> fix that problem. >> >> 2008/12/12 Ilya A. Volynets-Evenbakh <ilya@total-knowledge.com> >> >> >> >>> Hey. I just noticed that you made CWaiter destructor virtual. >>> I also noticed that it makes cppserv under valgrind hang while >>> accepting requests. >>> >>> Before I dive any further, why did you decide to make it virtual? >>> >>> Ilya. >>> >>> >>> >>> >> >> >> >> > > -- Alexey Parshin, http://www.sptk.net
List hosted by Total Knowledge